Skip to content

[playwright-browser-tunnel] Fix launch option for playwright tunnel #5688

Merged
TheLarkInn merged 3 commits into
microsoft:mainfrom
frags51:user/supsing/launch-options
Mar 6, 2026
Merged

[playwright-browser-tunnel] Fix launch option for playwright tunnel #5688
TheLarkInn merged 3 commits into
microsoft:mainfrom
frags51:user/supsing/launch-options

Conversation

@frags51
Copy link
Copy Markdown
Contributor

@frags51 frags51 commented Mar 6, 2026

Summary

These launch options are passed to the browser server started by the playwright tunnel. Playwright MCP passes the launch commands in a different searchParam - https://github.com/microsoft/playwright/blob/e1387929c9f1a9d5943611e44615a10ffca71518/packages/playwright-core/src/mcp/browser/browserContextFactory.ts#L159

This PR correctly consumes that param.

How it was tested

Tested manually through playwright tunnel in codespace.

Impacted documentation

@anarmawala
Copy link
Copy Markdown
Contributor

Also bump the version for the vscode-local-browser-tunnel-extension!

@frags51
Copy link
Copy Markdown
Contributor Author

frags51 commented Mar 6, 2026

@microsoft-github-policy-service agree company="Microsoft"

@TheLarkInn TheLarkInn enabled auto-merge (squash) March 6, 2026 00:46
@TheLarkInn TheLarkInn merged commit 68bd306 into microsoft:main Mar 6, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Needs triage to Closed in Bug Triage Mar 6, 2026
dmichon-msft pushed a commit to dmichon-msft/rushstack that referenced this pull request Mar 19, 2026
…icrosoft#5688)

* correct launch option

* rush change

* ext version bump

---------

Co-authored-by: supsing <supsing_microsoft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants